C++: Tidy up SubBasicBlocks.qll#1827
Merged
Merged
Conversation
These files are now added to `identical-files.json` so they will remain in sync.
Previously, the word "position" was used ambiguously in this library.
dave-bartolomeo
previously approved these changes
Aug 26, 2019
dave-bartolomeo
left a comment
dave-bartolomeo
left a comment
Contributor
There was a problem hiding this comment.
Changes all LGTM. Thanks especially for using "rank"/"index" instead of "pos".
This predicte was still used in a test, so it might be used in external code too.
Contributor
Author
|
Added two commits to fix the failing test. |
geoffw0
reviewed
Aug 28, 2019
| * returns a 0-based position, while `getRankInBasicBlock` returns a 1-based | ||
| * position. | ||
| */ | ||
| deprecated int getPosInBasicBlock(BasicBlock bb) { |
Contributor
There was a problem hiding this comment.
Why are we adding a deprecated predicate? Is there another part to this change?
Contributor
There was a problem hiding this comment.
... ah, looks like I was viewing an old version of the PR, or possibly a single commit.
Contributor
|
Time to merge this I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series of commits tidies up my rather crude performance fixes from #1824. I decided to leave one
pragma[nomagic]on a predicate that seemed to be sensitive to context in my experiments. TheSubBasicBlockslibrary is intended to be used in many different contexts.This PR does not have the 1.22 milestone. I believe the library in 1.22 is performant, correct, and well tested.